Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hybrid bigm formulation for linear trees #164

Merged
merged 10 commits into from
Dec 8, 2024

Conversation

emma58
Copy link
Contributor

@emma58 emma58 commented Oct 3, 2024

The changes in #163 included changes to the hybrid bigm formulation for linear tree that, while mathematically equivalent, made for a larger formulation in terms of number of constraints. This PR corrects that: It still uses the gdp.bound_pretransformation to generate the constraints bounding the features values for each leaf, but it manually transforms the constraints setting the output value to the leaf's linear function, equivalently to @bammari's original implementation. In addition it adds a test to check that the size of the resulting formulation is what is expected.

Legal Acknowledgement
By contributing to this software project, I agree my contributions are submitted under the BSD license.
I represent I am authorized to make the contributions and grant the license.
If my employer has rights to intellectual property that includes these contributions,
I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@jalving
Copy link
Collaborator

jalving commented Oct 4, 2024

It looks like the graph neural network notebook is failing. i'll have a look soon.

@jalving jalving self-requested a review October 4, 2024 17:58
Copy link

codecov bot commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.31%. Comparing base (321a2e2) to head (cf87696).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
+ Coverage   90.27%   90.31%   +0.04%     
==========================================
  Files          32       32              
  Lines        2005     2014       +9     
  Branches      460      316     -144     
==========================================
+ Hits         1810     1819       +9     
  Misses        123      123              
  Partials       72       72              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jalving
Copy link
Collaborator

jalving commented Dec 8, 2024

sorry this took awhile to get to @emma58

@jalving jalving merged commit e9e34b4 into cog-imperial:main Dec 8, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants