Quality of Life on client.extraction_pipelines.runs.list #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1322 +/- ##
==========================================
+ Coverage 91.78% 91.83% +0.04%
==========================================
Files 120 120
Lines 15579 15584 +5
==========================================
+ Hits 14299 14311 +12
+ Misses 1280 1273 -7
|
haakonvt
reviewed
Aug 20, 2023
|
I see |
doctrino
changed the title
doctrino
commented
Oct 5, 2023
haakonvt
reviewed
Oct 5, 2023
| @@ -33,6 +36,28 @@ def new_extpipe(cognite_client): | |||
| assert cognite_client.extraction_pipelines.retrieve(extpipe.id) is None | |||
|
|
|||
|
|
|||
| @pytest.fixture | |||
There was a problem hiding this comment.
Let's add some broader scoping here to avoid re-running for each test using it
There was a problem hiding this comment.
It is only used once, and due to the scope of new_extpipe, this cannot be made broader without rewriting all the tests below.
haakonvt
approved these changes
Nov 29, 2023
Comment on lines
+55
to
+58
| created = [] | ||
| for run in runs: | ||
| new_run = cognite_client.extraction_pipelines.runs.create(run) | ||
| created.append(new_run) |
…ta/cognite-sdk-python into add-extraction-pipeline-search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A small QoL improvement to the
client.extraction_pipelines.runs.listmethod.Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.