Bug wrong encoding when uploading Nordic characters through files API #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlendvollset
approved these changes
Oct 3, 2023
haakonvt
reviewed
Oct 3, 2023
Comment on lines
+548
to
+549
| if isinstance(content, str): | ||
| content = content.encode("utf-8") |
There was a problem hiding this comment.
Is this a Windows requests bug? Great catch anyway!
There was a problem hiding this comment.
actually, based on the bug it seems to also happen on unix systems.
doctrino
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1398 +/- ##
==========================================
- Coverage 90.64% 90.62% -0.02%
==========================================
Files 117 117
Lines 14216 14218 +2
==========================================
- Hits 12886 12885 -1
- Misses 1330 1333 +3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reference psf/requests#5560
Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.