DOGE-55: Fix dict snake case dump #1409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1409 +/- ##
==========================================
- Coverage 90.65% 90.63% -0.02%
==========================================
Files 119 119
Lines 14357 14361 +4
==========================================
+ Hits 13015 13016 +1
- Misses 1342 1345 +3
|
haakonvt
reviewed
Oct 6, 2023
| if camel_case: | ||
| return {to_camel_case(key): value for key, value in dct.items()} | ||
| else: | ||
| return {to_snake_case(key): value for key, value in dct.items()} |
There was a problem hiding this comment.
Can’t you use convert_dict_to_case?
|
@ddonukis this is still in draft? Or is it ready for review? |
|
This needs more work. |
|
Closing as v7 will fix this by removing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addressing issue: #1087
Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.