Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add subworkflow tasks to workflows #1445

Merged
merged 14 commits into from
Dec 6, 2023
Merged

Conversation

silvavelosa
Copy link
Contributor

@silvavelosa silvavelosa commented Oct 26, 2023

Description

Add support for subworkflow tasks

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • Changelog updated in CHANGELOG.md.
  • Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

@silvavelosa silvavelosa requested review from a team as code owners October 26, 2023 08:21
@silvavelosa silvavelosa requested review from a team and doctrino October 26, 2023 08:30
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #1445 (4e2b88d) into master (8fec922) will decrease coverage by 0.06%.
The diff coverage is 79.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1445      +/-   ##
==========================================
- Coverage   91.80%   91.74%   -0.06%     
==========================================
  Files         120      120              
  Lines       15599    15623      +24     
==========================================
+ Hits        14321    14334      +13     
- Misses       1278     1289      +11     
Files Coverage Δ
cognite/client/_version.py 100.00% <100.00%> (ø)
cognite/client/data_classes/__init__.py 100.00% <ø> (ø)
cognite/client/data_classes/workflows.py 94.65% <78.57%> (-1.07%) ⬇️

... and 2 files with indirect coverage changes

Copy link
Contributor

@doctrino doctrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor changes.

cognite/client/data_classes/workflows.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@silvavelosa silvavelosa requested a review from doctrino December 6, 2023 12:47
@silvavelosa silvavelosa merged commit 3ae8328 into master Dec 6, 2023
8 checks passed
@silvavelosa silvavelosa deleted the add-subworkflows-tasks branch December 6, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants