Added missing properties in ViewProperty.as_apply methods #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1500 +/- ##
==========================================
+ Coverage 90.97% 90.99% +0.01%
==========================================
Files 119 119
Lines 14410 14410
==========================================
+ Hits 13110 13112 +2
+ Misses 1300 1298 -2
|
| @@ -428,6 +429,7 @@ def as_apply(self) -> SingleHopConnectionDefinitionApply: | |||
| description=self.description, | |||
| edge_source=self.edge_source, | |||
| direction=self.direction, | |||
| connection_type=self.connection_type, | |||
There was a problem hiding this comment.
connection_type can just be removed from the constructor of this class. It's implicitly always multiEdgeConnection for this class.
There was a problem hiding this comment.
So it is more like a class variable?
erlendvollset
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
.apply()methods onSingleHopConnectionDefinitionandMappedPropertywere missing propertiesconnection_typeandsource.This is now fixed.
Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.