Fix filter dump in Data Modeling #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doctrino
commented
Nov 15, 2023
| @@ -68,8 +68,20 @@ def _dump_property(property_: PropertyReference, camel_case: bool) -> list[str] | |||
| class Filter(ABC): | |||
| _filter_name: str | |||
|
|
|||
| def dump(self, camel_case: bool = True) -> dict[str, Any]: | |||
| return {self._filter_name: self._filter_body(camel_case)} | |||
| def dump(self, camel_case_property: bool = False) -> dict[str, Any]: | |||
There was a problem hiding this comment.
This is the bug introduced in v7, the default was changed from False to True
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1510 +/- ##
==========================================
+ Coverage 91.62% 91.64% +0.02%
==========================================
Files 120 120
Lines 15605 15607 +2
==========================================
+ Hits 14298 14303 +5
+ Misses 1307 1304 -3
|
haakonvt
approved these changes
Nov 15, 2023
| @@ -193,7 +194,7 @@ def create_args(id_: Id) -> tuple[str, str, str | None, Literal["node", "edge"] | |||
| return id_[0], id_[1], None, id_type # type: ignore[return-value] | |||
| raise ValueError("Instance given as a tuple must have two elements (space, externalId)") | |||
| if isinstance(id_, tuple): | |||
| return id_[0], id_[1], id_[2] if len(id_) == 3 else None, None | |||
| return id_[0], id_[1], (id_[2] if len(id_) == 3 else None), None | |||
There was a problem hiding this comment.
Not sure if this is more readable or not, you choose 😜
Suggested change
| return id_[0], id_[1], (id_[2] if len(id_) == 3 else None), None | |
| return (*id_, None, None)[:4] |
There was a problem hiding this comment.
Can we catch this in a test?
There was a problem hiding this comment.
(nvm i see it's already done 💯)
There was a problem hiding this comment.
@erlendvollset That change was only for easier readability (not referring to my suggestion but his added parens)
| if instance.target is not None: | ||
| instance.target = instance._convert_resource(instance.target, instance.target_type) # type: ignore | ||
| instance.target = instance._convert_resource(instance.target, instance.target_type, cognite_client) # type: ignore |
| @@ -63,18 +64,18 @@ def __iter__(self) -> Iterator[Space]: | |||
| return self() | |||
|
|
|||
| @overload | |||
| def retrieve(self, spaces: str) -> Space | None: # type: ignore[overload-overlap] | |||
| def retrieve(self, spaces: str) -> Space | None: | |||
There was a problem hiding this comment.
Oooh nice! ...to get overloads working 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[7.0.3] - 2023-11-15
Fixed
cognite.client.data_classes.filterused with anydata_modelingendpoint raised aCogniteAPIErrorforsnake_cased properties. This is now fixed.
Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.