Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add intersects_bounding_box to 3D asset mapping API #1511

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

haakonvt
Copy link
Contributor

Description

[7.1.0] - 2023-11-16

Added

  • The list method for asset mappings in the 3D API now supports intersects_bounding_box, allowing users to only
    return asset mappings for assets whose bounding box intersects with the given bounding box.

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • Changelog updated in CHANGELOG.md.
  • Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

@haakonvt haakonvt requested review from a team as code owners November 16, 2023 00:05
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #1511 (813d761) into master (1932572) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1511      +/-   ##
==========================================
- Coverage   91.62%   91.55%   -0.07%     
==========================================
  Files         120      120              
  Lines       15607    15611       +4     
==========================================
- Hits        14300    14293       -7     
- Misses       1307     1318      +11     
Files Coverage Δ
cognite/client/_api/three_d.py 97.75% <100.00%> (+0.10%) ⬆️
cognite/client/_version.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Collaborator

@erlendvollset erlendvollset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@haakonvt haakonvt merged commit 3303c67 into master Nov 16, 2023
7 checks passed
@haakonvt haakonvt deleted the add-intersects-bounding-box branch November 16, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants