Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add client_credentials param to workflow execution trigger method #1512

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

haakonvt
Copy link
Contributor

Description

[7.1.0] - 2023-11-16

Added

  • The trigger method of the Workflow Execution API, now accepts a client_credentials to allow specifying specific
    credentials to run with. Previously, the current credentials set on the CogniteClient object doing the call would be used.

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • Changelog updated in CHANGELOG.md.
  • Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

@haakonvt haakonvt requested review from a team as code owners November 16, 2023 10:00
@haakonvt haakonvt force-pushed the workflow-trigger-accept-client-credz branch from f7559d7 to 0f8f6cc Compare November 16, 2023 10:48
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #1512 (97d1c44) into master (cc3940b) will decrease coverage by 0.08%.
The diff coverage is 33.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1512      +/-   ##
==========================================
- Coverage   91.64%   91.56%   -0.08%     
==========================================
  Files         120      120              
  Lines       15611    15611              
==========================================
- Hits        14306    14294      -12     
- Misses       1305     1317      +12     
Files Coverage Δ
cognite/client/_version.py 100.00% <100.00%> (ø)
cognite/client/_api/workflows.py 81.19% <0.00%> (ø)

... and 2 files with indirect coverage changes

@haakonvt haakonvt force-pushed the workflow-trigger-accept-client-credz branch from 0f8f6cc to 73f0cbc Compare November 16, 2023 14:51
@@ -39,6 +40,7 @@ def run_docstring_tests(module):


@patch("cognite.client.CogniteClient", CogniteClientMock)
@patch("os.environ", defaultdict(lambda: "value"))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small comment here would be nice.

@haakonvt haakonvt merged commit b855dc2 into master Nov 16, 2023
7 checks passed
@haakonvt haakonvt deleted the workflow-trigger-accept-client-credz branch November 16, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants