Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example on how to update the nonce for transformations #1517

Merged
merged 3 commits into from
Nov 23, 2023

Conversation

muradsater
Copy link
Contributor

Description

Extend docs for transformations update

Checklist:

  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.

@muradsater muradsater requested review from a team as code owners November 21, 2023 09:14
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #1517 (4abb31a) into master (30090f9) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1517      +/-   ##
==========================================
- Coverage   91.80%   91.78%   -0.03%     
==========================================
  Files         120      120              
  Lines       15587    15587              
==========================================
- Hits        14310    14306       -4     
- Misses       1277     1281       +4     
Files Coverage Δ
cognite/client/_api/transformations/__init__.py 76.66% <ø> (ø)

... and 2 files with indirect coverage changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this should accept a created session as well, would make the example much easier and more intuitive. Wdyt?

Also, please add some indentation to make it easier to read 🙏

Copy link
Contributor

@haakonvt haakonvt Nov 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't be done because the CreatedSession does not store a reference to the CogniteClient, so we don't know what project to pass.

@haakonvt haakonvt changed the title Add nonce sample doc Add example on how to update the nonce for transformations Nov 23, 2023
@haakonvt haakonvt force-pushed the add_nonce_sample_doc branch from 3b60160 to 5ec09ae Compare November 23, 2023 12:05
@haakonvt haakonvt merged commit 4543658 into master Nov 23, 2023
1 of 5 checks passed
@haakonvt haakonvt deleted the add_nonce_sample_doc branch November 23, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants