Remove "beta" warning for Units catalog [POFSP-195] #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1522 +/- ##
==========================================
+ Coverage 91.71% 91.83% +0.12%
==========================================
Files 120 120
Lines 15589 15579 -10
==========================================
+ Hits 14297 14307 +10
+ Misses 1292 1272 -20
|
haakonvt
force-pushed
the
update-units-api-spec-ref
branch
from
f8192d9 to
85f4d78
Compare
haakonvt
reviewed
Nov 23, 2023
| @@ -41,7 +38,7 @@ def retrieve(self, external_id: MutableSequence[str], ignore_unknown_ids: bool = | |||
| def retrieve( | |||
| self, external_id: str | MutableSequence[str], ignore_unknown_ids: bool = False | |||
| ) -> Unit | UnitList | None: | |||
| """`Retrieve one or more unit <https://pr-50.units-api.preview.cogniteapp.com/#tag/Units/operation/retrieve_units_by_ids_api_v1_projects__project__units_byids_post>`_ | |||
| """`Retrieve one or more unit <https://developer.cognite.com/api#tag/Units/operation/byIdsUnits>`_ | |||
There was a problem hiding this comment.
None of these urls seem to work yet?
There was a problem hiding this comment.
no, but they will be there once we merge https://github.com/cognitedata/service-contracts/pull/2375
There was a problem hiding this comment.
now they work @haakonvt
polomani
changed the title
haakonvt
approved these changes
Nov 24, 2023
cognite/client/_api/units.py
Outdated
| @@ -98,25 +95,22 @@ def __init__( | |||
| config: ClientConfig, | |||
| api_version: str | None, | |||
| cognite_client: CogniteClient, | |||
| warning: FeaturePreviewWarning, | |||
| ) -> None: | |||
| super().__init__(config, api_version, cognite_client) | |||
There was a problem hiding this comment.
You can remove this entire init method now.
Co-authored-by: Håkon V. Treider <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description