Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update outdated guide on client instantiation + remove API key reference #1524

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

haakonvt
Copy link
Contributor

Description

I saw a post on Cognite Hub referencing our documentation, which hasn't been updated after the introduction of the ClientConfig addition.

https://hub.cognite.com/developer-and-user-community-134/sdk-questions-around-global-config-2310?postid=7448#post7448

Checklist:

  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.

@haakonvt haakonvt requested review from a team as code owners November 23, 2023 12:43
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #1524 (2a1fea9) into master (4543658) will decrease coverage by 0.13%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1524      +/-   ##
==========================================
- Coverage   91.85%   91.72%   -0.13%     
==========================================
  Files         120      120              
  Lines       15589    15589              
==========================================
- Hits        14319    14299      -20     
- Misses       1270     1290      +20     

see 5 files with indirect coverage changes

@qTipTip qTipTip self-requested a review November 23, 2023 12:57
Copy link
Contributor

@qTipTip qTipTip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@haakonvt haakonvt merged commit e94205a into master Nov 23, 2023
7 checks passed
@haakonvt haakonvt deleted the update-docs-on-client-and-config branch November 23, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants