Added chain to and direction argument to expression result sets #1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doctrino
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1528 +/- ##
==========================================
- Coverage 91.83% 91.73% -0.10%
==========================================
Files 120 120
Lines 15584 15591 +7
==========================================
- Hits 14311 14302 -9
- Misses 1273 1289 +16
|
doctrino
force-pushed
the
add-chain-to-parameter
branch
from
adc297d to
26a8415
Compare
doctrino
changed the title
doctrino
changed the title
tests/utils.py
Outdated
| @@ -308,8 +308,12 @@ def create_instance(self, resource_cls: type[T_Object]) -> T_Object: | |||
| # DataPointSubscriptionCreate requires either timeseries_ids or filter | |||
| keyword_arguments.pop("filter", None) | |||
| if resource_cls is Query: | |||
| key_count = min(len(keyword_arguments["select"]), len(keyword_arguments["with_"])) | |||
There was a problem hiding this comment.
There should never be fewer result expressions than selects.
There was a problem hiding this comment.
This is from the FakeCogniteResourceGenerator this is just to ensure that the with_ and select arguments ends up with the same number of entries (they are both randomly generated based on the init signature, and since they are dict they are of random lengths). I have simplified the code to attempt to make it clearer.
doctrino
force-pushed
the
add-chain-to-parameter
branch
from
43a6909 to
d4c09f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New parameter:
Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.