Geospatial - added missing allowDimensionalityMismatch parameter #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1531 +/- ##
==========================================
- Coverage 91.73% 91.73% -0.01%
==========================================
Files 120 120
Lines 15904 15903 -1
==========================================
- Hits 14590 14588 -2
- Misses 1314 1315 +1
|
haakonvt
reviewed
Nov 30, 2023
* improved docstrings * passing bool params directly to api because it works * split large tests
haakonvt
reviewed
Dec 4, 2023
haakonvt
reviewed
Dec 4, 2023
haakonvt
approved these changes
Dec 4, 2023
implemented inputs from review: * changed exception handling in tests to use with pytest.raises
|
@skepticalcat ping 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Geospatial API comes with parameter "
allowDimensionalityMismatch" forsearch_featuresandstream_features, which was missing in the python SDK.Added the parameter.
Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.