Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

post-v7 improvements & fixes #1533

Merged
merged 5 commits into from
Dec 4, 2023
Merged

post-v7 improvements & fixes #1533

merged 5 commits into from
Dec 4, 2023

Conversation

haakonvt
Copy link
Contributor

@haakonvt haakonvt commented Nov 29, 2023 •
edited
Loading

Description

  1. fix flaky test test_list_partitions_with_failure
  2. housecleaning on .github/workflows/*
  3. handle single acl passed to Group init + update docstring
  4. make capabilities errors always print example usage

@haakonvt haakonvt force-pushed the post-v7-improvements branch from fc26ae3 to d8800ef Compare December 4, 2023 09:41
@haakonvt haakonvt changed the title Post v7 improvements post-v7 improvements & fixes Dec 4, 2023
@haakonvt haakonvt marked this pull request as ready for review December 4, 2023 09:42
@haakonvt haakonvt requested review from a team as code owners December 4, 2023 09:42
@haakonvt haakonvt force-pushed the post-v7-improvements branch from d8800ef to 34061cb Compare December 4, 2023 09:50
erlendvollset
erlendvollset approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@erlendvollset erlendvollset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! 👌

@codecov Codecov
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #1533 (22eda3e) into master (88c6211) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1533      +/-   ##
==========================================
- Coverage   91.76%   91.68%   -0.08%     
==========================================
  Files         120      120              
  Lines       15593    15600       +7     
==========================================
- Hits        14309    14303       -6     
- Misses       1284     1297      +13
Files Coverage Δ
cognite/client/data_classes/capabilities.py 96.96% <100.00%> (+0.02%) ⬆️
cognite/client/data_classes/iam.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

@haakonvt haakonvt enabled auto-merge (squash) December 4, 2023 10:03
@haakonvt haakonvt merged commit 6529464 into master Dec 4, 2023
8 checks passed
@haakonvt haakonvt deleted the post-v7-improvements branch December 4, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlendvollset erlendvollset erlendvollset approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haakonvt @erlendvollset