Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import in docs for filters.Not #1535

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

sighol
Copy link
Contributor

@sighol sighol commented Dec 1, 2023

Description

The Not filter had imports for Or and Equals in the docs, when it should have Not and `Equals.

Since this is just docs, I don't think we need a new version of the SDK. The public docs should be re-built when this PR is merged.

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • Changelog updated in CHANGELOG.md.
  • Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

@sighol sighol requested review from a team as code owners December 1, 2023 12:21
@erlendvollset erlendvollset enabled auto-merge (squash) December 1, 2023 12:24
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #1535 (7825382) into master (6ec2c15) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1535      +/-   ##
==========================================
- Coverage   91.75%   91.75%   -0.01%     
==========================================
  Files         120      120              
  Lines       15591    15591              
==========================================
- Hits        14306    14305       -1     
- Misses       1285     1286       +1     
Files Coverage Δ
cognite/client/data_classes/filters.py 98.07% <ø> (ø)

... and 1 file with indirect coverage changes

@erlendvollset erlendvollset merged commit 296353c into master Dec 1, 2023
8 checks passed
@erlendvollset erlendvollset deleted the fix-filter-documentation-typo branch December 1, 2023 12:26
@haakonvt
Copy link
Contributor

haakonvt commented Dec 1, 2023

How was this not picked up by the doctests?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants