Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail on client instantiation if base_url is None or empty string #1536

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

erlendvollset
Copy link
Collaborator

Description

Please describe the change you have made.

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • Changelog updated in CHANGELOG.md.
  • Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

@erlendvollset erlendvollset requested review from a team as code owners December 1, 2023 12:26
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #1536 (68d6e2c) into master (6ec2c15) will increase coverage by 0.07%.
Report is 1 commits behind head on master.
The diff coverage is 66.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1536      +/-   ##
==========================================
+ Coverage   91.75%   91.82%   +0.07%     
==========================================
  Files         120      120              
  Lines       15591    15593       +2     
==========================================
+ Hits        14306    14319      +13     
+ Misses       1285     1274      -11     
Files Coverage Δ
cognite/client/_version.py 100.00% <100.00%> (ø)
cognite/client/config.py 86.44% <50.00%> (-1.28%) ⬇️

... and 3 files with indirect coverage changes

Copy link
Contributor

@haakonvt haakonvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@erlendvollset erlendvollset enabled auto-merge (squash) December 1, 2023 13:03
@erlendvollset erlendvollset added the auto-update Will automatically keep PR up to date label Dec 1, 2023
@erlendvollset erlendvollset merged commit f147ab5 into master Dec 1, 2023
7 checks passed
@erlendvollset erlendvollset deleted the client-config-validation branch December 1, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Will automatically keep PR up to date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants