Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix WorkflowDefinitionUpsert storing built-in hash function #1539

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

haakonvt
Copy link
Contributor

@haakonvt haakonvt commented Dec 4, 2023

Description

Belongs in the subclass only, the READ version (and not hash, but "hash from API").

Also adds a test.

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • Changelog updated in CHANGELOG.md.
  • Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

@haakonvt haakonvt requested review from a team as code owners December 4, 2023 20:35
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #1539 (443dd7b) into master (6529464) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1539      +/-   ##
==========================================
+ Coverage   91.75%   91.76%   +0.01%     
==========================================
  Files         120      120              
  Lines       15600    15599       -1     
==========================================
+ Hits        14313    14314       +1     
+ Misses       1287     1285       -2     
Files Coverage Δ
cognite/client/_version.py 100.00% <100.00%> (ø)
cognite/client/data_classes/workflows.py 95.71% <ø> (-0.02%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Contributor

@doctrino doctrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@haakonvt haakonvt merged commit 8fec922 into master Dec 5, 2023
8 checks passed
@haakonvt haakonvt deleted the fix-WorkflowDefinitionUpsert branch December 5, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants