Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing container error #1561

Merged
merged 5 commits into from
Dec 21, 2023
Merged

Fix missing container error #1561

merged 5 commits into from
Dec 21, 2023

Conversation

doctrino
Copy link
Contributor

@doctrino doctrino commented Dec 21, 2023

Description

The change from #1540 is not backwards compatible and breaks multiple tools built on top of the SDK.

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • Changelog updated in CHANGELOG.md.
  • Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

@doctrino doctrino marked this pull request as ready for review December 21, 2023 14:49
@doctrino doctrino requested review from a team as code owners December 21, 2023 14:49
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Merging #1561 (f27f6df) into master (b820d9f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1561      +/-   ##
==========================================
+ Coverage   91.76%   91.78%   +0.02%     
==========================================
  Files         120      120              
  Lines       15880    15887       +7     
==========================================
+ Hits        14572    14582      +10     
+ Misses       1308     1305       -3     
Files Coverage Δ
cognite/client/_version.py 100.00% <100.00%> (ø)
cognite/client/data_classes/data_modeling/views.py 95.25% <100.00%> (+0.09%) ⬆️

... and 2 files with indirect coverage changes

@doctrino doctrino merged commit a083ff5 into master Dec 21, 2023
8 checks passed
@doctrino doctrino deleted the fix-missing-container-error branch December 21, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants