Fix type hint to transformations.preview #1784
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1784 +/- ##
=======================================
Coverage 50.39% 50.39%
=======================================
Files 119 119
Lines 17502 17502
=======================================
Hits 8821 8821
Misses 8681 8681
|
| @@ -502,7 +502,7 @@ def preview( | |||
| self, | |||
| query: str | None = None, | |||
| convert_to_string: bool = False, | |||
| limit: int = 100, | |||
| limit: int | None = 100, | |||
There was a problem hiding this comment.
-
Does it work to pass None for all?
-
Also, I see that the API spec uses 10k for inferSchemaLimit instead of the 1k in the SDK. Perhaps update as well?
-
Looks like
timeouti also missing from the params
There was a problem hiding this comment.
Yes it work for None, will fix the other issues.
There was a problem hiding this comment.
Cool, I wonder why we call it preview if you can page through unlimited results? 🤔
There was a problem hiding this comment.
I think because you are actually not writing the results to the destination.
doctrino
force-pushed
the
fix-typehint-preview
branch
from
0e67182 to
3dec2da
Compare
Description
Please describe the change you have made.
Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.