Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sessions cleaning for data workflows tests #1788

Merged
merged 1 commit into from
May 30, 2024

Conversation

VerstraeteBert
Copy link
Contributor

Description

Sessions are revoked by data workflows. No need to revoke the sessions after tests anymore.

Checklist:

  • Tests added/updated.

@VerstraeteBert VerstraeteBert requested review from a team as code owners May 30, 2024 09:48
@VerstraeteBert VerstraeteBert requested review from vvb16 and removed request for a team May 30, 2024 09:48
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.47%. Comparing base (90b1d5e) to head (c212a0b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1788      +/-   ##
==========================================
+ Coverage   50.39%   50.47%   +0.07%     
==========================================
  Files         119      119              
  Lines       17502    17502              
==========================================
+ Hits         8821     8834      +13     
+ Misses       8681     8668      -13     

see 3 files with indirect coverage changes

@VerstraeteBert VerstraeteBert merged commit bf4cc5a into master May 30, 2024
12 checks passed
@VerstraeteBert VerstraeteBert deleted the remove-session-cleaning branch May 30, 2024 13:49
@haakonvt
Copy link
Contributor

haakonvt commented May 30, 2024

I know who I'm coming after if our session quota is maxed @VerstraeteBert 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants