Add dropna option to RawRowsAPI.insert_dataframe
#1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1789 +/- ##
==========================================
+ Coverage 93.00% 93.01% +0.01%
==========================================
Files 121 121
Lines 17673 17688 +15
==========================================
+ Hits 16436 16453 +17
+ Misses 1237 1235 -2
|
doctrino
approved these changes
May 31, 2024
CHANGELOG.md
Outdated
| ## [7.44.1] - 2024-05-24 | ||
| ### Added | ||
| - Missing parameter `timeout` to `client.transformations.preview`. | ||
| - Missing parameter `timeout` to `client.transformations.preview`. |
There was a problem hiding this comment.
Time for an end-of-line linter?
There was a problem hiding this comment.
I think it will screw up a couple of the tests that rely on output matching. This change here is done automatically by my editor 😅
| "f": [100, 200, 300], | ||
| } | ||
| ) | ||
| df.columns = ["a", "b", "a", "c", "a", "b"] |
There was a problem hiding this comment.
Why not set columns above with the data?
There was a problem hiding this comment.
Notice the duplicates 😉
haakonvt
force-pushed
the
add-raw-rows-insert-dropna
branch
from
4db0b81 to
243f314
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[7.44.2] - 2024-05-30
Added
RawRowsAPI.insert_dataframenow has a newdropnasetting (defaulting to True, as this would otherwise raise later).Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.