add last_updated_time_in_index to retrieve_dataframe
#1846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch makes index into multi-index. Also updated docstring
KristianVangsnes
requested review from
mattmurph9
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1846 +/- ##
=======================================
Coverage 91.05% 91.06%
=======================================
Files 124 124
Lines 19245 19247 +2
=======================================
+ Hits 17524 17527 +3
+ Misses 1721 1720 -1
|
haakonvt
reviewed
Jul 11, 2024
|
Where would be best to add the test? tests_unit/test_api/test_raw.py? |
Yup! |
haakonvt
reviewed
Jul 22, 2024
cognite/client/_api/raw.py
Outdated
Comment on lines
759
to
761
| idx = pd.MultiIndex.from_tuples( | ||
| [(r.key, r.last_updated_time) for r in rows], names=["key", "last_updated_time"] | ||
| ) |
There was a problem hiding this comment.
Should we convert epoch-ms to datetime?
There was a problem hiding this comment.
Good questions, I don't see why not.
haakonvt
reviewed
Jul 22, 2024
haakonvt
approved these changes
Jul 25, 2024
haakonvt
changed the title
last_updated_time_in_index to retrieve_dataframe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding last_updated_time_in_index to retrieve_dataframe function, which makes index into multi-index. Also updated docstring.
Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.