Updated core model to version with required keywords and docstrings #1864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1864 +/- ##
==========================================
- Coverage 91.06% 91.06% -0.01%
==========================================
Files 124 124
Lines 19245 19245
==========================================
- Hits 17526 17525 -1
- Misses 1719 1720 +1
|
haakonvt
reviewed
Jul 25, 2024
scripts/generate_core_model.py
Outdated
CHANGELOG.md
Outdated
Comment on lines
24
to
25
|
|
||
|
|
Comment on lines
23
to
24
| class CogniteDescribableNodeApply(CogniteDescribableProperties, TypedNodeApply): | ||
| """This represents the writing format of cognite describable node. |
There was a problem hiding this comment.
Quite a lot of lower-cased cognite:
Suggested change
| class CogniteDescribableNodeApply(CogniteDescribableProperties, TypedNodeApply): | |
| """This represents the writing format of cognite describable node. | |
| class CogniteDescribableNodeApply(CogniteDescribableProperties, TypedNodeApply): | |
| """This represents the writing format of Cognite describable node. |
Comment on lines
+67
to
+68
|
|
||
|
|
Comment on lines
+4609
to
+4610
|
|
||
|
|
haakonvt
changed the title
haakonvt
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
3Dcorrectly:object_3dinstead ofobject_3_dChecklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.