-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor OAuthDeviceCode to support non-Entra IdPs #1892
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1892 +/- ##
==========================================
- Coverage 90.32% 90.18% -0.14%
==========================================
Files 133 133
Lines 21131 21200 +69
==========================================
+ Hits 19086 19119 +33
- Misses 2045 2081 +36
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried the flow and fails with the following error
cognite.client.exceptions.CogniteAuthError: Error generating access token! Error: invalid_client, error description: AADSTS7000218: The request body must contain the following parameter: 'client_assertion' or 'client_secret'. Trace ID: f0fb6991-ed32-4acd-953f-d8f5f333fe00 Correlation ID: 7d3ffed0-ee7d-4412-ba3a-b3a0915947ad Timestamp: 2024-09-02 14:32:11
In addition, some nitpick.
…_code_oauth2 # Conflicts: # cognite/client/credentials.py
Description
Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.