Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug datetime parsing #1906

Merged
merged 8 commits into from
Sep 4, 2024
Merged

Bug datetime parsing #1906

merged 8 commits into from
Sep 4, 2024

Conversation

doctrino
Copy link
Contributor

@doctrino doctrino commented Sep 3, 2024

Description

From User

image

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • Changelog updated in CHANGELOG.md.
  • Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

@doctrino doctrino force-pushed the datatime-conversion branch from 1b2fadb to 5cbf491 Compare September 3, 2024 13:33
@doctrino doctrino marked this pull request as ready for review September 3, 2024 13:35
@doctrino doctrino requested review from a team as code owners September 3, 2024 13:35
@doctrino doctrino requested review from erlendvollset and removed request for a team September 3, 2024 13:35
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.77%. Comparing base (929adcb) to head (476f1b1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1906      +/-   ##
==========================================
+ Coverage   90.74%   90.77%   +0.02%     
==========================================
  Files         130      130              
  Lines       20106    20112       +6     
==========================================
+ Hits        18245    18256      +11     
+ Misses       1861     1856       -5     
Files with missing lines Coverage Δ
cognite/client/_version.py 100.00% <100.00%> (ø)
...ient/data_classes/data_modeling/typed_instances.py 92.04% <100.00%> (+0.04%) ⬆️
cognite/client/utils/_time.py 95.01% <100.00%> (+0.07%) ⬆️

... and 4 files with indirect coverage changes

@doctrino doctrino requested a review from haakonvt September 4, 2024 06:43
@doctrino doctrino merged commit 51910e0 into master Sep 4, 2024
14 checks passed
@doctrino doctrino deleted the datatime-conversion branch September 4, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants