Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fdm filters should accept list of objects #1908

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

haakonvt
Copy link
Contributor

@haakonvt haakonvt commented Sep 4, 2024

Description

https://cognitedata.atlassian.net/browse/DM-2066?atlOrigin=eyJpIjoiNTc1ZDljMDg4NmFhNDA5MTk1NTNiZGQ5YTdhMjliNTciLCJwIjoiaiJ9

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • Changelog updated in CHANGELOG.md.
  • Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

@haakonvt haakonvt requested review from a team as code owners September 4, 2024 08:49
@haakonvt haakonvt requested review from dimitryhoff and removed request for a team September 4, 2024 08:49
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.82%. Comparing base (c4db741) to head (eeb5331).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cognite/client/data_classes/filters.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1908      +/-   ##
==========================================
+ Coverage   90.75%   90.82%   +0.07%     
==========================================
  Files         130      130              
  Lines       20109    20113       +4     
==========================================
+ Hits        18249    18267      +18     
+ Misses       1860     1846      -14     
Files with missing lines Coverage Δ
cognite/client/_version.py 100.00% <100.00%> (ø)
cognite/client/data_classes/filters.py 94.98% <91.66%> (+0.06%) ⬆️

... and 4 files with indirect coverage changes

@haakonvt haakonvt force-pushed the fix-filters-to-accept-lists branch from df6b2ba to eeb5331 Compare September 4, 2024 09:40
Copy link
Contributor

@doctrino doctrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe update the API spec as well. I cannot see that reflected here
image

@haakonvt haakonvt enabled auto-merge (squash) September 4, 2024 09:41
@haakonvt haakonvt merged commit 8c537f1 into master Sep 4, 2024
14 checks passed
@haakonvt haakonvt deleted the fix-filters-to-accept-lists branch September 4, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants