Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core ReadOnly Properties #1909

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Core ReadOnly Properties #1909

merged 1 commit into from
Sep 4, 2024

Conversation

doctrino
Copy link
Contributor

@doctrino doctrino commented Sep 4, 2024

Description

Please describe the change you have made.

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • Changelog updated in CHANGELOG.md.
  • Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

@doctrino doctrino requested review from a team as code owners September 4, 2024 09:34
@doctrino doctrino requested review from haakonvt and removed request for a team September 4, 2024 09:34
@doctrino doctrino enabled auto-merge (squash) September 4, 2024 09:38
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (51910e0) to head (6611b9f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1909      +/-   ##
==========================================
- Coverage   90.76%   90.75%   -0.02%     
==========================================
  Files         130      130              
  Lines       20112    20109       -3     
==========================================
- Hits        18255    18249       -6     
- Misses       1857     1860       +3     
Files with missing lines Coverage Δ
...ognite/client/data_classes/data_modeling/cdm/v1.py 54.91% <ø> (-0.17%) ⬇️

... and 2 files with indirect coverage changes

@doctrino doctrino merged commit c4db741 into master Sep 4, 2024
14 checks passed
@doctrino doctrino deleted the update-core-readonly branch September 4, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants