Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

override methods inherited from Instance in Typed[Node/Edge] #1910

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

haakonvt
Copy link
Contributor

@haakonvt haakonvt commented Sep 4, 2024

No description provided.

@haakonvt haakonvt requested review from a team as code owners September 4, 2024 11:02
@haakonvt haakonvt requested review from vvb16 and removed request for a team September 4, 2024 11:02
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 52.38095% with 10 lines in your changes missing coverage. Please review.

Project coverage is 90.72%. Comparing base (8c537f1) to head (240125b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ient/data_classes/data_modeling/typed_instances.py 52.38% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1910      +/-   ##
==========================================
- Coverage   90.75%   90.72%   -0.04%     
==========================================
  Files         130      130              
  Lines       20113    20133      +20     
==========================================
+ Hits        18254    18266      +12     
- Misses       1859     1867       +8     
Files with missing lines Coverage Δ
...ient/data_classes/data_modeling/typed_instances.py 87.75% <52.38%> (-4.30%) ⬇️

... and 4 files with indirect coverage changes

@haakonvt haakonvt merged commit 32f224d into master Sep 4, 2024
14 checks passed
@haakonvt haakonvt deleted the update-typed-instance-class-methods branch September 4, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants