[fix] Zipping files older than 1980 #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1914 +/- ##
=======================================
Coverage 90.86% 90.86%
=======================================
Files 130 130
Lines 20157 20157
=======================================
Hits 18315 18315
Misses 1842 1842
|
qTipTip
commented
Sep 5, 2024
| @@ -58,7 +58,8 @@ | |||
|
|
|||
| MAX_RETRIES = 5 | |||
| REQUIREMENTS_FILE_NAME = "requirements.txt" | |||
| REQUIREMENTS_REG = re.compile(r"(\[\/?requirements\]){1}$", flags=re.M) # Matches [requirements] and [/requirements] | |||
There was a problem hiding this comment.
Most of the changes here are linting fmt.
Co-authored-by: Håkon V. Treider <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From the docs: https://docs.python.org/3/library/zipfile.html#zipfile.ZipFile
The strict_timestamps argument, when set to False, allows to zip files older than 1980-01-01 at the cost of setting the timestamp to 1980-01-01. Similar behavior occurs with files newer than 2107-12-31, the timestamp is also set to the limit.
We have been seeing some of these errors when creating functions lately. Not sure why they sporadically show up:
Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.