Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change of double type is handled. #1916

Merged
merged 6 commits into from
Sep 6, 2024
Merged

Change of double type is handled. #1916

merged 6 commits into from
Sep 6, 2024

Conversation

doctrino
Copy link
Contributor

@doctrino doctrino commented Sep 6, 2024

Description

Please describe the change you have made.

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • Changelog updated in CHANGELOG.md.
  • Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

@doctrino doctrino marked this pull request as ready for review September 6, 2024 10:59
@doctrino doctrino requested review from a team as code owners September 6, 2024 10:59
@doctrino doctrino requested review from dimitryhoff and removed request for a team September 6, 2024 10:59
Copy link
Collaborator

@erlendvollset erlendvollset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doctrino doctrino enabled auto-merge (squash) September 6, 2024 11:54
@doctrino doctrino merged commit b825dd8 into master Sep 6, 2024
13 checks passed
@doctrino doctrino deleted the typed-type branch September 6, 2024 12:00
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.86%. Comparing base (4eac890) to head (2005da6).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ognite/client/data_classes/data_modeling/cdm/v1.py 60.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1916   +/-   ##
=======================================
  Coverage   90.85%   90.86%           
=======================================
  Files         130      130           
  Lines       20153    20153           
=======================================
+ Hits        18311    18313    +2     
+ Misses       1842     1840    -2     
Files with missing lines Coverage Δ
cognite/client/_version.py 100.00% <100.00%> (ø)
...a_classes/data_modeling/extractor_extensions/v1.py 0.00% <ø> (ø)
...ognite/client/data_classes/data_modeling/cdm/v1.py 58.15% <60.00%> (ø)

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants