Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing workflowtrigger list #1920

Merged
merged 5 commits into from
Sep 10, 2024

Conversation

doctrino
Copy link
Contributor

Description

Please describe the change you have made.

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • Changelog updated in CHANGELOG.md.
  • Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

@doctrino doctrino requested review from a team as code owners September 10, 2024 13:41
@doctrino doctrino requested review from vvb16 and removed request for a team September 10, 2024 13:41
CHANGELOG.md Outdated
@@ -17,6 +17,10 @@ Changes are grouped as follows
- `Fixed` for any bug fixes.
- `Security` in case of vulnerabilities.

## [7.58.8] - 2024-09-06
### Fixed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Fixed
### Added

CHANGELOG.md Outdated
@@ -17,6 +17,10 @@ Changes are grouped as follows
- `Fixed` for any bug fixes.
- `Security` in case of vulnerabilities.

## [7.58.8] - 2024-09-06
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## [7.58.8] - 2024-09-06
## [7.58.8] - 2024-09-10

Copy link
Contributor

@haakonvt haakonvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haakonvt
Copy link
Contributor

@doctrino I believe tests are failing due to #oncall-240910-elasticsearch_low_disk_space_critical

@doctrino doctrino added auto-update Will automatically keep PR up to date auto-merge labels Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.86%. Comparing base (b825dd8) to head (9c5e9e6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1920      +/-   ##
==========================================
- Coverage   90.86%   90.86%   -0.01%     
==========================================
  Files         130      130              
  Lines       20153    20157       +4     
==========================================
+ Hits        18312    18315       +3     
- Misses       1841     1842       +1     
Files with missing lines Coverage Δ
cognite/client/_version.py 100.00% <100.00%> (ø)
cognite/client/data_classes/__init__.py 100.00% <ø> (ø)
cognite/client/data_classes/workflows.py 94.94% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

@cognite-bulldozer cognite-bulldozer bot merged commit df2ed53 into master Sep 10, 2024
14 checks passed
@cognite-bulldozer cognite-bulldozer bot deleted the add-missing-workflowtrigger-list branch September 10, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge auto-update Will automatically keep PR up to date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants