Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /models/statistics #2095

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add /models/statistics #2095

wants to merge 4 commits into from

Conversation

haakonvt
Copy link
Contributor

@haakonvt haakonvt commented Jan 17, 2025

Adds:

  • /models/statistics
  • /models/statistics/spaces
  • /models/statistics/spaces/byids

TODO:

@haakonvt haakonvt requested review from a team as code owners January 17, 2025 01:22
@haakonvt haakonvt force-pushed the add-dm-models-statistics branch from 7e11bca to aba9755 Compare January 17, 2025 01:23
@haakonvt haakonvt changed the title Add /models/statistics Add /models/statistics Jan 17, 2025
@erlendvollset
Copy link
Collaborator

Nice! Let's hold off on this until we publish the API though. I don't think we need to break anything, but I'm not 100% sure. Let's do a sync next week.

@haakonvt haakonvt force-pushed the add-dm-models-statistics branch from de65751 to 2bed274 Compare January 17, 2025 22:23
@haakonvt
Copy link
Contributor Author

How pandas viz in notebooks:
image
(could potentially be nicer? a lot is hidden in 'instances)

The other I'm pretty much happy with:
image

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 75.63025% with 29 lines in your changes missing coverage. Please review.

Project coverage is 90.61%. Comparing base (73fe764) to head (2bed274).

Files with missing lines Patch % Lines
...te/client/data_classes/data_modeling/statistics.py 73.49% 22 Missing ⚠️
cognite/client/_api/data_modeling/statistics.py 74.07% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2095      +/-   ##
==========================================
- Coverage   90.69%   90.61%   -0.08%     
==========================================
  Files         149      151       +2     
  Lines       22880    22996     +116     
==========================================
+ Hits        20750    20838      +88     
- Misses       2130     2158      +28     
Files with missing lines Coverage Δ
cognite/client/_api/data_modeling/__init__.py 100.00% <100.00%> (ø)
cognite/client/data_classes/data_modeling/ids.py 92.61% <100.00%> (ø)
cognite/client/testing.py 100.00% <100.00%> (ø)
cognite/client/utils/_pandas_helpers.py 86.04% <100.00%> (+0.33%) ⬆️
cognite/client/_api/data_modeling/statistics.py 74.07% <74.07%> (ø)
...te/client/data_classes/data_modeling/statistics.py 73.49% <73.49%> (ø)

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants