Cognite-SDK v7 #262
Merged
Cognite-SDK v7 #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doctrino
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #262 +/- ##
==========================================
+ Coverage 78.69% 78.70% +0.01%
==========================================
Files 22 22
Lines 1920 1921 +1
==========================================
+ Hits 1511 1512 +1
Misses 409 409
|
haakonvt
reviewed
Nov 16, 2023
Co-authored-by: Håkon V. Treider <[email protected]>
mathialo
reviewed
Nov 21, 2023
There was a problem hiding this comment.
There is a version number in __init__.py as well which should be kept in sync.
But since this is already a breaking change we can just remove that, it's mostly a leftover from the pre-poetry days of the library. So you can also just remove it.
mathialo
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.