Use a shared base class for the file upload queues #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
einarmo
force-pushed
the
base-file-upload-queue
branch
from
837a47b to
552c756
Compare
This class can also be used directly to load data that is neither a local file or an in-memory byte buffer, for example if data is actively being streamed from somewhere else.
einarmo
force-pushed
the
base-file-upload-queue
branch
from
552c756 to
d67c8d2
Compare
einarmo
force-pushed
the
base-file-upload-queue
branch
from
3fdf591 to
0f40dd1
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #265 +/- ##
==========================================
+ Coverage 78.69% 78.74% +0.04%
==========================================
Files 22 22
Lines 1920 1896 -24
==========================================
- Hits 1511 1493 -18
+ Misses 409 403 -6
|
mathialo
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class can also be used directly to load data that is neither a local file or an in-memory byte buffer, for example if data is actively being streamed from somewhere else.