Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statestore: Retry on connection errors #273

Merged
merged 4 commits into from
Dec 13, 2023
Merged

Statestore: Retry on connection errors #273

merged 4 commits into from
Dec 13, 2023

Conversation

amorken
Copy link
Contributor

@amorken amorken commented Dec 13, 2023

The SDK doesn't return a requests ConnectionError when it fails to connect, it returns a CogniteConnectionError. Retry on CogniteException to retry both CogniteAPIErrors and CogniteConnectionErrors.

The SDK doesn't return a requests ConnectionError when it fails to connect, it returns a CogniteConnectionError. Retry on CogniteException to retry both CogniteAPIErrors and CogniteConnectionErrors.
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #273 (f57c1a1) into master (7983f2e) will decrease coverage by 0.05%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
- Coverage   78.73%   78.69%   -0.05%     
==========================================
  Files          22       22              
  Lines        1919     1920       +1     
==========================================
  Hits         1511     1511              
- Misses        408      409       +1     
Files Coverage Δ
cognite/extractorutils/__init__.py 100.00% <100.00%> (ø)
cognite/extractorutils/statestore.py 91.30% <100.00%> (-0.05%) ⬇️

... and 2 files with indirect coverage changes

@amorken amorken marked this pull request as ready for review December 13, 2023 09:46
@amorken amorken requested a review from a team as a code owner December 13, 2023 09:46
Copy link
Collaborator

@mathialo mathialo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

There's a version number in __init__.py which also needs updating, and please add a little line in the changelog about the release :)

@amorken
Copy link
Contributor Author

amorken commented Dec 13, 2023

I'd squash the last two commits into the former, but meh I never bothered cloning this repo, I did it all in the github editor... x_x

@amorken amorken merged commit a21efcb into master Dec 13, 2023
6 checks passed
@amorken amorken deleted the statestore-retries branch December 13, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants