Lock when synchronization the state store #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We encountered: > Unexpected error while synchronizing state store: dictionary changed size during iteration. In this case, it is from an extractor with its own statestore that builds upon the internal one, which may make this worse, but when reviewing the code it seems we did not lock when inserting the state to raw. This was probably the cause for the above error. In the same way, we were serializing it in the JSON backed state store without locking the underlying dict, which may in theory also cause this. If we are concerned with long lock times around the insert, we could make a lock, copy the state store, unlock and then insert/iterate over that copy. It is a bit unclear if that is really needed.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #275 +/- ##
==========================================
+ Coverage 79.07% 79.12% +0.04%
==========================================
Files 22 22
Lines 2065 2069 +4
==========================================
+ Hits 1633 1637 +4
Misses 432 432
|
mathialo
approved these changes
Feb 19, 2024
mathialo
force-pushed
the
add-some-more-locking-
branch
from
72531cb to
6f5703f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We encountered:
In this case, it is from an extractor with its own statestore that builds upon the internal one, which may make this worse, but when reviewing the code it seems we did not lock when inserting the state to raw. This was probably the cause for the above error. In the same way, we were serializing it in the JSON backed state store without locking the underlying dict, which may in theory also cause this.
If we are concerned with long lock times around the insert, we could make a lock, copy the state store, unlock and then insert/iterate over that copy. It is a bit unclear if that is really needed.