Retry on requests.exceptions.ConnectionError (again) #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a previous PR, we switched from retrying on requests connection errors to the internal Cognite exceptions that wrapped these. This fixed some of the issues encountered by the customer (SLB). But, in some corner cases, such as for authorization, you can still get an unwrapped requests.exceptions.ConnectionError (as seen by the customer). This re-adds the retry on ConnectionError in addition to the internal Cognite SDK classes, to be more resilient.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #282 +/- ##
==========================================
- Coverage 78.73% 78.71% -0.02%
==========================================
Files 22 22
Lines 1970 1973 +3
==========================================
+ Hits 1551 1553 +2
- Misses 419 420 +1
|
rsjr
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous PR, we switched from retrying on requests connection errors to the internal Cognite exceptions that wrapped these. This fixed some of the issues encountered by the customer (SLB).
But, in some corner cases, such as for authorization, you can still get an unwrapped requests.exceptions.ConnectionError (as encountered by the customer). So we have to retry on both.
This re-adds the retry on ConnectionError in addition to the internal Cognite SDK classes, to be more resilient.