DOCS 1484: Update DB Extractor schema JSON #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #290 +/- ##
==========================================
- Coverage 79.56% 79.53% -0.03%
==========================================
Files 22 22
Lines 2001 2003 +2
==========================================
+ Hits 1592 1593 +1
- Misses 409 410 +1 |
mathialo
reviewed
Feb 9, 2024
schema/metrics_config.schema.json
Outdated
| @@ -57,36 +57,36 @@ | |||
| }, | |||
| "asset-name": { | |||
| "type": "string", | |||
| "description": "Enter the name for a CDF asset that will have all the metrics time series attached to it." | |||
| "description": "Enter the name for a CDF asset with all the metrics time series attached to it." | |||
There was a problem hiding this comment.
The asset might not yet exist, we will set all the time series on it, which why it was written in the tense it was
Co-authored-by: Mathias Lohne <[email protected]>
Co-authored-by: Mathias Lohne <[email protected]>
Co-authored-by: Mathias Lohne <[email protected]>
Co-authored-by: Mathias Lohne <[email protected]>
mathialo
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.