Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unstable: Set up logging in extractor based on application config #405

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

mathialo
Copy link
Collaborator

No description provided.

@mathialo mathialo requested a review from a team as a code owner November 29, 2024 13:49
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 32.35294% with 23 lines in your changes missing coverage. Please review.

Project coverage is 74.00%. Comparing base (658fa18) to head (65fcadd).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cognite/extractorutils/unstable/core/base.py 20.68% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
- Coverage   74.49%   74.00%   -0.49%     
==========================================
  Files          41       41              
  Lines        3313     3343      +30     
==========================================
+ Hits         2468     2474       +6     
- Misses        845      869      +24     
Files with missing lines Coverage Δ
...te/extractorutils/unstable/configuration/models.py 85.90% <100.00%> (+0.19%) ⬆️
cognite/extractorutils/unstable/core/base.py 60.55% <20.68%> (-7.87%) ⬇️

... and 1 file with indirect coverage changes

@mathialo mathialo merged commit 444bff5 into master Dec 2, 2024
5 checks passed
@mathialo mathialo deleted the setup-logging branch December 2, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants