Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-components): avoid fetching classic asset mappings when in coredm only and recache all revisionIds when requesting the connections with views #4946

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

danpriori
Copy link
Contributor

Type of change

Bug

Jira ticket 📘

https://cognitedata.atlassian.net/browse/

Description 📝

This fixes the use of Rule Based in projects with CoreDM Only, avoiding the need to fetch classic asset mappings to avoid triggering an error and making the Rule Based process unfeasible.

It also redoes the fdm cache when the cache request is made together with the views, because even when requesting the cache with views, the system was returning without the views because the revision IDs were already cached, causing problems when the user activates/deactivates the button to view all asset mappings of the model and then tries to activate some Rule Based Coloring, which needs the Views and uses this same cache to process the rule criteria.

How has this been tested? 🔍

Tested locally with the quickstart project in 3d test

Test instructions ℹ️

  1. Login into Search with 3d-dev-quickstart project
  2. Go to Browse 3D and select Hakon Scene
  3. Enable any Rules from Color overlay dropdown before and after toggling the asset mappings button

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

… all revisionIds when request the connecitons with views
…c-asset-mappings-when-dm-only-and-fix-fdm-cache-with-views
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant