Adding parameters to allow more fine-grained control of cut generation #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
febattista
reviewed
Oct 30, 2024
src/MibSBilevel.cpp
Outdated
| @@ -420,6 +427,7 @@ MibSBilevel::checkBilevelFeasibility(bool isRoot) | |||
| }else{ | |||
| startTimeVF = model_->broker_->subTreeTimer().getTime(); | |||
| lSolver->branchAndBound(); | |||
| lSolver->writeLp("water"); | |||
There was a problem hiding this comment.
I think this is a typo, shouldn't this be commented out?
src/MibSCutGenerator.cpp
Outdated
| (ISICGenStrategy == MibSIDICGenStrategyLInt || | ||
| ISICGenStrategy == MibSIDICGenStrategyAlways || | ||
| (ISICGenStrategy == MibSIDICGenStrategyAlwaysRoot && | ||
| localModel_->activeNode_->getDepth() == 0))))){ |
There was a problem hiding this comment.
I can't make sense out of this straightforwardly. Here the code should decide whether to undertake the generation of an IDIC, but is checking for the bilevel free set type for ISIC and whether an improving solution is available or not. Moreover, I might be wrong but I guess here ISICGenStrategy should be replaced with IDICGenStrategy.
| ISICGenStrategy == MibSIDICGenStrategyAlways || | ||
| (ISICGenStrategy == MibSIDICGenStrategyAlwaysRoot && | ||
| localModel_->activeNode_->getDepth() == 0))))){ | ||
| cutType = MibSIntersectionCutImprovingSolution; |
There was a problem hiding this comment.
Similarly as above, I guess MibSIDICGenStrategyYInt, MibSIDICGenStrategyAlways and MibSIDICGenStrategyAlwaysRoot should be replaced with MibSISICGenStrategyYInt, MibSISICGenStrategyAlways and MibSISICGenStrategyAlwaysRoot, respectively.
…n linking variables are not integer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.