make eth_chainId comply with spec (#1310)

* make eth_chainId comply with spec * test
coinbase · May 30, 2024 · 354ca64 · 354ca64
1 parent f74ba03
commit 354ca64
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/packages/wallet-sdk/src/CoinbaseWalletProvider.test.ts b/packages/wallet-sdk/src/CoinbaseWalletProvider.test.ts
@@ -27,7 +27,7 @@ describe('CoinbaseWalletProvider', () => {
     test('handles request correctly', async () => {
       const provider = createProvider();
       const response1 = await provider.request({ method: 'eth_chainId' });
-      expect(response1).toBe(1);
+      expect(response1).toBe('0x1');
     });
 
     test('throws error when handling invalid request', async () => {

diff --git a/packages/wallet-sdk/src/CoinbaseWalletProvider.ts b/packages/wallet-sdk/src/CoinbaseWalletProvider.ts
@@ -107,6 +107,7 @@ export class CoinbaseWalletProvider extends EventEmitter implements ProviderInte
       };
       switch (request.method) {
         case 'eth_chainId':
+          return hexStringFromIntNumber(IntNumber(this.chain.id));
         case 'net_version':
           return this.chain.id;
         case 'eth_accounts':