ethereum.setAppParams

coinbase · Oct 23, 2024 · 7ba8572 · 7ba8572
1 parent ee59560
commit 7ba8572
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 5 deletions.
diff --git a/packages/wallet-sdk/src/util/provider.test.ts b/packages/wallet-sdk/src/util/provider.test.ts
@@ -1,6 +1,7 @@
 import { vi } from 'vitest';
 
 import {
+  CBInjectedProvider,
   CBWindow,
   checkErrorForInvalidRequestArgs,
   fetchRPCRequest,
@@ -110,11 +111,10 @@ describe('Utils', () => {
     });
 
     describe('Browser Provider', () => {
-      class MockCipherProviderClass {
-        public isCoinbaseBrowser = true;
-      }
-
-      const mockCipherProvider = new MockCipherProviderClass() as unknown as ProviderInterface;
+      const mockCipherProvider = {
+        isCoinbaseBrowser: true,
+        setAppParams: vi.fn(),
+      } as unknown as CBInjectedProvider;
 
       beforeAll(() => {
         window.coinbaseWalletExtension = undefined;
@@ -138,6 +138,12 @@ describe('Utils', () => {
             },
           })
         ).toBe(mockCipherProvider);
+        expect(mockCipherProvider.setAppParams).toHaveBeenCalledWith({
+          appName: 'Dapp',
+          appChainIds: [],
+          appLogoUrl: null,
+          options: 'all',
+        });
       });
 
       it('smartWalletOnly - Should still return injected browser provider', () => {
@@ -153,6 +159,12 @@ describe('Utils', () => {
             },
           })
         ).toBe(mockCipherProvider);
+        expect(mockCipherProvider.setAppParams).toHaveBeenCalledWith({
+          appName: 'Dapp',
+          appChainIds: [],
+          appLogoUrl: null,
+          options: 'smartWalletOnly',
+        });
       });
 
       it('should handle exception when accessing window.top', () => {

diff --git a/packages/wallet-sdk/src/util/provider.ts b/packages/wallet-sdk/src/util/provider.ts
@@ -36,6 +36,7 @@ export interface CBWindow {
 export interface CBInjectedProvider extends ProviderInterface {
   isCoinbaseBrowser?: boolean;
   setAppInfo?: (...args: unknown[]) => unknown;
+  setAppParams?: (params: Record<string, unknown>) => void;
 }
 
 function getCoinbaseInjectedLegacyProvider(): CBInjectedProvider | undefined {
@@ -52,6 +53,16 @@ function getInjectedEthereum(): CBInjectedProvider | undefined {
   }
 }
 
+function flattenParams({
+  metadata,
+  preference,
+}: Readonly<ConstructorOptions>): Record<string, unknown> {
+  return {
+    ...metadata,
+    ...preference,
+  };
+}
+
 export function getCoinbaseInjectedProvider({
   metadata,
   preference,
@@ -67,6 +78,7 @@ export function getCoinbaseInjectedProvider({
 
   const ethereum = getInjectedEthereum();
   if (ethereum?.isCoinbaseBrowser) {
+    ethereum.setAppParams?.(flattenParams({ metadata, preference }));
     return ethereum;
   }