Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test matrix (remove node 16 and 18) #1424

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Conversation

cb-jake
Copy link
Contributor

@cb-jake cb-jake commented Oct 9, 2024

Summary

Update test matrix (remove node 16 and 18)

https://nodejs.org/en/about/previous-releases

image

How did you test your changes?

Unit Tests

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 9, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link
Contributor

@nateReiners nateReiners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@fan-zhang-sv
Copy link
Contributor

helping @cb-jake merging this PR

@fan-zhang-sv fan-zhang-sv merged commit 34d90e8 into master Oct 9, 2024
5 checks passed
@fan-zhang-sv fan-zhang-sv deleted the node-test-support branch October 9, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants