Passing SDK config params to injected provider #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Heimdall Review Status
|
fan-zhang-sv
changed the title
fan-zhang-sv
commented
Oct 23, 2024
| if (preference.options !== 'smartWalletOnly') { | ||
| const extension = getCoinbaseInjectedLegacyProvider(); | ||
| if (extension) { | ||
| const { appName, appLogoUrl, appChainIds } = metadata; | ||
| extension.setAppInfo?.(appName, appLogoUrl, appChainIds); | ||
| extension.setAppInfo?.(appName, appLogoUrl, appChainIds, preference); |
There was a problem hiding this comment.
adding it for extension too, just in case we need to use it, no harm even if we dont
There was a problem hiding this comment.
Did you test this on the extension side? Maybe include a video in the PR description?
cb-jake
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
extended the setAppInfo pattern to RN's in app browser provider.
This is used to block EOA account to connect to smartWalletOnly app, and also enables adding data suffix in future RN smart wallet account
we are passing flattened params, including metadata and preference, this is for maximizing compatibility across App SDK version in case of future App SDK config structure change
How did you test your changes?
Manually, demo attached in RN's PR
Demo: noop on current extension
Screen.Recording.2024-10-25.at.1.35.03.PM.mov