Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove enable call from playground #1437

Merged
merged 1 commit into from
Oct 24, 2024
Merged

remove enable call from playground #1437

merged 1 commit into from
Oct 24, 2024

Conversation

cb-jake
Copy link
Contributor

@cb-jake cb-jake commented Oct 23, 2024

Summary

remove enable call from playground from sdk playground submit call.

This was always firing and is not actually useful.

How did you test your changes?

Manually.

Just use the sdk playground. There should be no functional changes to how things work.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 23, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@cb-heimdall
Copy link
Collaborator

Review Error for fan-zhang-sv @ 2024-10-23 21:33:31 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

@cb-jake cb-jake merged commit bae2bea into master Oct 24, 2024
8 checks passed
@cb-jake cb-jake deleted the remove-enable-call branch October 24, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants