Create CryptoKey Lib for linked accounts #1498
Conversation
✅ Heimdall Review Status
|
cb-jake
force-pushed
the
jake/crypto-key-module
branch
from
3e67aff to
8c71fc8
Compare
cb-jake
requested review from
eric-ships,
montycheese,
fan-zhang-sv and
arjun-dureja
| }; | ||
| }; | ||
|
|
||
| return { |
There was a problem hiding this comment.
Where are we exporting the getSigner implementation?
There was a problem hiding this comment.
getCryptoKeyAccount is a 1:1 for the getSigner function. Just named it to be more explicit on the ck side
libs/crypto-key/README.md
Outdated
| @@ -0,0 +1 @@ | |||
| # crypto-key | |||
There was a problem hiding this comment.
suggest having a minimal readme here, since devs who want to bring their own key implementation would use this as a reference
There was a problem hiding this comment.
Good callout! Added some basic docs. Will update as I start consuming the package with some "how tos"
|
Review Error for montycheese @ 2025-01-31 18:42:03 UTC |
| const sign = async (payload: Hex.Hex) => { | ||
| const { payload: message, metadata } = WebAuthnP256.getSignPayload({ | ||
| challenge: payload, | ||
| origin: 'https://keys.coinbase.com', |
There was a problem hiding this comment.
is this something we need to allow overriding (e.g. via env) for local testing
There was a problem hiding this comment.
@montycheese Great question. I believe if we were using a passkey vs a cryptokey this would need configured to the apps origin
Summary
This PR adds a new lib called
crypto-keywhich creates a new account for creating sub accounts.How did you test your changes?
Unit tests