Skip to content

Commit

Permalink
Merge pull request #110 from coinbase/jingwei/remove-fields-preprocess
Browse files Browse the repository at this point in the history
[preprocess]remove max_fee and mulltiplier in preprocess request
  • Loading branch information
jingweicb authored Sep 19, 2022
2 parents f9e2a02 + 26ff9dd commit f831629
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 37 deletions.
13 changes: 1 addition & 12 deletions api.json
Original file line number Diff line number Diff line change
Expand Up @@ -2002,7 +2002,7 @@
}
},
"ConstructionPreprocessRequest": {
"description":"ConstructionPreprocessRequest is passed to the `/construction/preprocess` endpoint so that a Rosetta implementation can determine which metadata it needs to request for construction. Metadata provided in this object should NEVER be a product of live data (i.e. the caller must follow some network-specific data fetching strategy outside of the Construction API to populate required Metadata). If live data is required for construction, it MUST be fetched in the call to `/construction/metadata`. The caller can provide a max fee they are willing to pay for a transaction. This is an array in the case fees must be paid in multiple currencies. The caller can also provide a suggested fee multiplier to indicate that the suggested fee should be scaled. This may be used to set higher fees for urgent transactions or to pay lower fees when there is less urgency. It is assumed that providing a very low multiplier (like 0.0001) will never lead to a transaction being created with a fee less than the minimum network fee (if applicable). In the case that the caller provides both a max fee and a suggested fee multiplier, the max fee will set an upper bound on the suggested fee (regardless of the multiplier provided).",
"description":"ConstructionPreprocessRequest is passed to the `/construction/preprocess` endpoint so that a Rosetta implementation can determine which metadata it needs to request for construction. Metadata provided in this object should NEVER be a product of live data (i.e. the caller must follow some network-specific data fetching strategy outside of the Construction API to populate required Metadata). If live data is required for construction, it MUST be fetched in the call to `/construction/metadata`.",
"type":"object",
"required": [
"network_identifier",
Expand All @@ -2020,17 +2020,6 @@
},
"metadata": {
"type":"object"
},
"max_fee": {
"type":"array",
"items": {
"$ref":"#/components/schemas/Amount"
}
},
"suggested_fee_multiplier": {
"type":"number",
"format":"double",
"minimum": 0
}
}
},
Expand Down
25 changes: 0 additions & 25 deletions api.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1211,23 +1211,6 @@ components:
data fetching strategy outside of the Construction API to populate
required Metadata). If live data is required for construction, it MUST
be fetched in the call to `/construction/metadata`.
The caller can provide a max fee they are willing
to pay for a transaction. This is an array in the case fees
must be paid in multiple currencies.
The caller can also provide a suggested fee multiplier
to indicate that the suggested fee should be scaled.
This may be used to set higher fees for urgent transactions
or to pay lower fees when there is less urgency. It is assumed
that providing a very low multiplier (like 0.0001) will
never lead to a transaction being created with a fee
less than the minimum network fee (if applicable).
In the case that the caller provides both a max fee
and a suggested fee multiplier, the max fee will set an
upper bound on the suggested fee (regardless of the
multiplier provided).
type: object
required:
- network_identifier
Expand All @@ -1241,14 +1224,6 @@ components:
$ref: '#/components/schemas/Operation'
metadata:
type: object
max_fee:
type: array
items:
$ref: '#/components/schemas/Amount'
suggested_fee_multiplier:
type: number
format: double
minimum: 0.0
ConstructionPreprocessResponse:
description: |
ConstructionPreprocessResponse contains `options` that will
Expand Down

0 comments on commit f831629

Please sign in to comment.