-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase gas limit #48
Conversation
Also, this only makes updates for Nimbus validators and I have not tested this beyond the config change. Not sure if 50M is the right value will launch some testnet validators at 50M to see how it goes. |
Thanks for your PR! Nimbus appears to require the config change on the Nimbus CL configuration, but your change on the Nimbus VC might work too. 36M is the right value as of Dec 2024, as can be checked on As for where the gas limit is modified, the docs suggest Consensus Client ( for externally produced blocks with MEVboost)
|
Its a bit confusing as to what needs to get reconfigured. I think most people use MEV external block builders, so didn't think EthPillar needed to add the config option to the Execution Clients. For Consensus Clients, not sure if the Consensus or Validator, or both need to set the flag to the higher value. My PR was only for the validator. But having 2 things to change is a bit confusing. But setting two client config from one menu item also seemed pretty confusing. Not even sure what happens if only one is set? Potential foot-gun, for sure. |
I thought the recommended increase was 20M, not 20%..LOL...
I think I'm going to close out this PR. After looking into this whole topic, I'm not sure this kind of config change deserves a spot in the system. I think it might be simpler/better to just let the client teams change their defaults when the gas limit is actually increased. Anyone that wants to signal higher gas can change their config directly... |
Agreed, especially on the last point. Those motivated will change. Defaults in clients are coming or already here. 👍 for engaging and iterating on this PR. |
This is more of a feature request than a PR ready to merge. It would be great to be able to change the suggested gas limit for my validator.
I've made some possible changes, but TBH, not sure what the proper way should be to config the gas limit. It interacts with MEV and not sure if/how the EC should be configured.
This PR does not change the CSM_VC, or the EC, which probably need to have similar changes.
Happy to make more updates to this if there is a preferred approach.